Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Inject the --block option to ray start command automatically #915

Closed
2 tasks done
kevin85421 opened this issue Feb 20, 2023 · 0 comments · Fixed by #932
Closed
2 tasks done

[Feature] Inject the --block option to ray start command automatically #915

kevin85421 opened this issue Feb 20, 2023 · 0 comments · Fixed by #932
Assignees
@kevin85421
Labels
enhancement New feature or request
Milestone
v0.5.0 release

Comments

@kevin85421
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

#675 (comment)

With --block, when the ray process crashes, the KubeRay operator can detect the unhealthy condition in a short time because the container will exit immediately. Without --block, the unhealthy condition can still be detected by both readiness and liveness probes, but it may take more time to detect it.

Use case

No response

Related issues

#675
#912

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin85421 kevin85421

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0 release
Development

Successfully merging a pull request may close this issue.

Inject the --block option to ray start command automatically Yicheng-Lu-llll/kuberay
1 participant
@kevin85421