Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Expose loadBalancerIP for head service to users #877

Closed
2 tasks done
kevin85421 opened this issue Jan 20, 2023 · 2 comments · Fixed by #1040
Closed
2 tasks done

[Feature] Expose loadBalancerIP for head service to users #877

kevin85421 opened this issue Jan 20, 2023 · 2 comments · Fixed by #1040
Assignees
Labels
enhancement New feature or request

Comments

@kevin85421
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Users may want Ray head to be accessible from outside Kubernetes. One option is to use Kubernetes Service with type LoadBalancer and specify loadBalancerIP. However, KubeRay currently does not expose loadBalancerIP to users. See https://discuss.ray.io/t/specify-ip-adress-for-the-head-as-a-loadbalancer-service-type/9008 for more details.

Use case

No response

Related issues

https://discuss.ray.io/t/specify-ip-adress-for-the-head-as-a-loadbalancer-service-type/9008

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added the enhancement New feature or request label Jan 20, 2023
@kevin85421
Copy link
Member Author

KubeRay originally only exposed serviceType to users. Then, we found that it is not enough, and thus exposed custom annotations and labels.

I currently have two thoughts:

  • Only expose loadBalancerIP in this PR.
  • Expose multiple fields (e.g. service.spec) to users once.

Any thoughts? cc @DmitriGekhtman @architkulkarni @Jeffwan

@DmitriGekhtman
Copy link
Collaborator

DmitriGekhtman commented Jan 20, 2023

We should expose as many fields as people ask for.

Probably we should have just exposed the entire service (maybe we did in the initial version?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants