Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] [RayJob] Support entrypoint_num_cpus, gpus, resources arguments #1266

Closed
2 tasks done
architkulkarni opened this issue Jul 24, 2023 · 1 comment · Fixed by #1359
Closed
2 tasks done

[Feature] [RayJob] Support entrypoint_num_cpus, gpus, resources arguments #1266

architkulkarni opened this issue Jul 24, 2023 · 1 comment · Fixed by #1359
Assignees
@architkulkarni
Labels
enhancement New feature or request P1 Issue that should be fixed within a few weeks

Comments

@architkulkarni
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

https://docs.ray.io/en/latest/cluster/running-applications/job-submission/sdk.html#specifying-cpu-and-gpu-resources

The Ray Job API supports specifying resources, but these options are not exposed as fields in the KubeRay RayJob spec. We should add them.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@architkulkarni architkulkarni added enhancement New feature or request P1 Issue that should be fixed within a few weeks labels Jul 24, 2023
@architkulkarni architkulkarni self-assigned this Jul 24, 2023
@architkulkarni architkulkarni mentioned this issue Aug 4, 2023
Open
@shubhscoder shubhscoder mentioned this issue Aug 22, 2023
Merged
4 tasks
@shubhscoder
Copy link
Contributor

Apolgies for the delay, I was stuck with some unforseen circumstances! I have started working on this issue and raised a PR (WIP) right now. I expect to complete it today EOD. Thanks for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@architkulkarni architkulkarni

Labels
enhancement New feature or request P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add field to expose entrypoint num cpus in rayjob shubhscoder/kuberay
2 participants
@architkulkarni @shubhscoder