From f7dcf2ab7b9adfd5b04eb9206c06bb584612958b Mon Sep 17 00:00:00 2001 From: Wilson Wang Date: Mon, 17 Jan 2022 19:00:36 -0800 Subject: [PATCH] udpate format --- .github/workflows/test-job.yaml | 2 +- apiserver/cmd/main.go | 2 +- apiserver/pkg/interceptor/interceptor.go | 1 + apiserver/pkg/manager/client_manager.go | 1 - apiserver/pkg/server/cluster_server.go | 4 ++-- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test-job.yaml b/.github/workflows/test-job.yaml index a1221c30e17..33169cec1a3 100644 --- a/.github/workflows/test-job.yaml +++ b/.github/workflows/test-job.yaml @@ -77,7 +77,7 @@ jobs: run: test -z "$(set -o pipefail && $(go env GOPATH)/bin/goimports -l . | tee goimports.out)" || { cat goimports.out && exit 1; } - name: Open this to see how to fix goimports if it fails - run: echo Run goimports -w . + run: echo Run goimports -d . if: failure() - name: list directories diff --git a/apiserver/cmd/main.go b/apiserver/cmd/main.go index eaa698a20d0..a46d44f59a9 100644 --- a/apiserver/cmd/main.go +++ b/apiserver/cmd/main.go @@ -15,10 +15,10 @@ import ( "k8s.io/klog/v2" "github.com/prometheus/client_golang/prometheus/promhttp" - api "github.com/ray-project/kuberay/proto/go_client" "github.com/ray-project/kuberay/apiserver/pkg/interceptor" "github.com/ray-project/kuberay/apiserver/pkg/manager" "github.com/ray-project/kuberay/apiserver/pkg/server" + api "github.com/ray-project/kuberay/proto/go_client" ) var ( diff --git a/apiserver/pkg/interceptor/interceptor.go b/apiserver/pkg/interceptor/interceptor.go index d1fee31772e..c609a2babb0 100644 --- a/apiserver/pkg/interceptor/interceptor.go +++ b/apiserver/pkg/interceptor/interceptor.go @@ -2,6 +2,7 @@ package interceptor import ( "context" + "google.golang.org/grpc" "k8s.io/klog/v2" ) diff --git a/apiserver/pkg/manager/client_manager.go b/apiserver/pkg/manager/client_manager.go index af58479c696..e0f8edcbd25 100644 --- a/apiserver/pkg/manager/client_manager.go +++ b/apiserver/pkg/manager/client_manager.go @@ -35,7 +35,6 @@ func (c *ClientManager) Time() util.TimeInterface { return c.time } - func (c *ClientManager) init() { // db, kubernetes initialization klog.Info("Initializing client manager") diff --git a/apiserver/pkg/server/cluster_server.go b/apiserver/pkg/server/cluster_server.go index 0eaadd59271..7d0d9593999 100644 --- a/apiserver/pkg/server/cluster_server.go +++ b/apiserver/pkg/server/cluster_server.go @@ -2,10 +2,11 @@ package server import ( "context" + "github.com/golang/protobuf/ptypes/empty" - api "github.com/ray-project/kuberay/proto/go_client" "github.com/ray-project/kuberay/apiserver/pkg/manager" "github.com/ray-project/kuberay/apiserver/pkg/util" + api "github.com/ray-project/kuberay/proto/go_client" ) type ClusterServerOptions struct { @@ -42,7 +43,6 @@ func (s *ClusterServer) DeleteCluster(ctx context.Context, request *api.DeleteCl panic("Implement me") } - func ValidateCreateClusterRequest(request *api.CreateClusterRequest) error { if request.Cluster.Name == "" { return util.NewInvalidInputError("Cluster name is empty. Please specify a valid value.")