Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Get fails on blackfriday module #26

Open
nlynchjo opened this issue Oct 2, 2019 · 4 comments
Open

Go Get fails on blackfriday module #26

nlynchjo opened this issue Oct 2, 2019 · 4 comments

Comments

@nlynchjo
Copy link

nlynchjo commented Oct 2, 2019

I saw a similar issue (#25), but think this might be slightly different.

My Travis-CI jobs recently started failing using Go 1.12.1 due to blackfriday/v2 modules not found? Could this be a Travis-CI issue instead for their Go environment? I did see recent changes to use modules instead: 1c8cb96

I can reproduce locally on go1.13.1 linux/amd64
From clean environment:

$ go version 
go version go1.13.1 linux/amd64
$ go get -u github.com/raviqqe/liche
package github.com/russross/blackfriday/v2: cannot find package "github.com/russross/blackfriday/v2" in any of:
	/usr/local/go/src/github.com/russross/blackfriday/v2 (from $GOROOT)
	/home/nlynchjo/go/src/github.com/russross/blackfriday/v2 (from $GOPATH)

And my Travis-CI logs:

$ go version
go version go1.12.10 linux/amd64
go.env
$ go env
9.89s$ go get -u github.com/raviqqe/liche
package github.com/russross/blackfriday/v2: cannot find package "github.com/russross/blackfriday/v2" in any of:
	/home/travis/.gimme/versions/go1.12.10.linux.amd64/src/github.com/russross/blackfriday/v2 (from $GOROOT)
	/home/travis/gopath/src/github.com/russross/blackfriday/v2 (from $GOPATH)
The command "go get -u github.com/raviqqe/liche" failed and exited with 1 during .
@nlynchjo
Copy link
Author

nlynchjo commented Oct 2, 2019

oh! just saw your comment! 1c8cb96#commitcomment-35321223 please disregard if addressed already!

@sponomarev
Copy link

It's still an issue

go get -u github.com/raviqqe/liche
package github.com/russross/blackfriday/v2: cannot find package "github.com/russross/blackfriday/v2" in any of:
	/usr/local/Cellar/go/1.13.1/libexec/src/github.com/russross/blackfriday/v2 (from $GOROOT)
	/Users/toad/go/src/github.com/russross/blackfriday/v2 (from $GOPATH)

@raviqqe
Copy link
Owner

raviqqe commented Oct 14, 2019

Can you use Go modules with Go >1.11?

@josehelps
Copy link
Contributor

@raviqqe you got it, after setting export GO111MODULE=on and updating to go version go1.13.4 darwin/amd64 things worked as expected! I created a PR to make a note of this in the README: #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants