Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck at extracting if the executable is located at the root of a network share/drive #608

Closed
kevwkev opened this issue Mar 20, 2023 · 8 comments

Comments

@kevwkev
Copy link

kevwkev commented Mar 20, 2023

For example if the executable is located at \network_share, the updater will stuck at the extracting sequence.
If the executable is located at \network_share\any folder, the updater can extract and and update the exe successfully.

@ravibpatel
Copy link
Owner

I tried placing the file in the root of a network share, but it still updated successfully. Can you provide the ZipExtractor.log file that is created in "%temp%" folder? It will give better info about the issue.

@fishjimi
Copy link
Contributor

fishjimi commented Apr 26, 2023

I got stucked too, but I was put app in driver root like D:\ instead of \network_share.
The logs was created after I click close button

image

2023-04-26 20:01:19

ZipExtractor started with following command line arguments.
[0] c:\users\jimifish\appdata\local\temp\zipextractor.exe
[1] --input
[2] c:\users\jimifish\appdata\local\temp\brc.zip
[3] --output
[4] d:" --current-exe d:\brc.exe

2023-04-26 20:03:02

ZipExtractor started with following command line arguments.
[0] c:\users\jimifish\appdata\local\temp\zipextractor.exe
[1] --input
[2] c:\users\jimifish\appdata\local\temp\brc.zip
[3] --output
[4] d:" --current-exe d:\brc.exe

2023-04-26 20:05:11

ZipExtractor started with following command line arguments.
[0] c:\users\jimifish\appdata\local\temp\zipextractor.exe
[1] --input
[2] c:\users\jimifish\appdata\local\temp\brc.zip
[3] --output
[4] d:" --current-exe d:\brc.exe

@fishjimi
Copy link
Contributor

I created a PR to fix this problem #616

@ravibpatel
Copy link
Owner

ravibpatel commented Apr 27, 2023

@kevwkev This should be fixed in latest commit. Can you try it from here?

@kevwkev kevwkev changed the title Stuck at extracting if the execute is located at the root of a network share/drive Stuck at extracting if the executable is located at the root of a network share/drive Apr 27, 2023
@kevwkev
Copy link
Author

kevwkev commented Apr 30, 2023

@ravibpatel I can confirm the issue is resolved. Thank you for the fix!

@kevwkev
Copy link
Author

kevwkev commented May 1, 2023

@ravibpatel could you please also update the NuGet package to 1.8.1 Thanks in advance!

@ravibpatel
Copy link
Owner

I tagged the new release. It should be available on NuGet soon.

@fishjimi
Copy link
Contributor

fishjimi commented May 1, 2023

@ravibpatel Thank you, Im going to update the new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants