Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting seems weird for many Elixir Kernel SpecialForms and Macros #34

Open
andykent opened this issue Jan 2, 2024 · 1 comment

Comments

@andykent
Copy link

andykent commented Jan 2, 2024

Syntax highlighting for many in-built keywords seems to be a bit odd. I think at least some of this may be a regression since the recent 0.4.7 release but not 100% certain, I'm certainly noticing it more recently.

Below is a screenshot showing some of the weirdness. I note:

  • def foo seems to highlight differently from def foo(). The def foo highlighting looks better and easier to scan but def foo() is more consistent with the other highlighting.
  • do and `end seem to highlight correctly (purple in this case) but the other SpecialForms / Macros that would be considered keywords in many languages don't highlight differently to other function calls which leads to code often looking quite unbalanced.
  • I'm not 100% sure what the correct behaviour is in all these cases but in daily use it doesn't feel like it's quite right currently.
Screenshot 2024-01-02 at 15 49 30
@raulchedrese
Copy link
Owner

@andykent Thanks for taking the time to submit an issue. I agree this doesn't seem quite right. I don't think I'll have time to look at this soon but if you're interested in taking a crack at it I suspect we just need to tweak the tree-sitter queries here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants