Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyManagementProvider should check if contentType matches value #1459

Closed
1 task done
susanshi opened this issue May 9, 2024 · 1 comment
Closed
1 task done

KeyManagementProvider should check if contentType matches value #1459

susanshi opened this issue May 9, 2024 · 1 comment
Assignees
@susanshi
Labels
bug Something isn't working triage Needs investigation
Milestone
v1.2.0

Comments

@susanshi
Copy link
Collaborator

susanshi commented May 9, 2024

What happened in your environment?

I incorrectly specified the content Type to be "Certificate" instead of "Keys" for my KMP resource, i expected isSuccessStatus to be false, the actual value of isSuccess is true.

What did you expect to happen?

No response

What version of Kubernetes are you running?

No response

What version of Ratify are you running?

No response

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this bug fix?

  • Yes, I am willing to implement it.
@susanshi susanshi added bug Something isn't working triage Needs investigation labels May 9, 2024
@susanshi susanshi self-assigned this May 9, 2024
@akashsinghal akashsinghal added this to the v1.2.0 milestone May 13, 2024
@susanshi
Copy link
Collaborator Author

fixed by PR #1470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susanshi susanshi

Labels
bug Something isn't working triage Needs investigation
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@susanshi @akashsinghal