Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type field to store/policy json config #1284

Open
1 task
binbin-li opened this issue Jan 29, 2024 · 1 comment
Open
1 task

Add type field to store/policy json config #1284

binbin-li opened this issue Jan 29, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@binbin-li
Copy link
Collaborator

What would you like to be added?

When we configure store or policy through CRD, the metadata.name is the real name for this resource, and spec.name behaves as type. When we refactored verifier, verifier json config already supported both name and type fields so that users could set multiple verifiers of the same type.
We should also add type field to store and policy json config so that all resources have consistent behavior in CLI mode.

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@binbin-li binbin-li added enhancement New feature or request triage Needs investigation labels Jan 29, 2024
@luisdlp luisdlp removed the triage Needs investigation label Jan 30, 2024
@luisdlp luisdlp added this to the Future milestone Jan 30, 2024
@luisdlp
Copy link
Collaborator

luisdlp commented Jan 30, 2024

Tackle during CLI scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants