Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support debug logging as a flag in Ratify CLI #1165

Closed
1 task
akashsinghal opened this issue Nov 6, 2023 · 2 comments · Fixed by #1188
Closed
1 task

Support debug logging as a flag in Ratify CLI #1165

akashsinghal opened this issue Nov 6, 2023 · 2 comments · Fixed by #1188
Assignees
@Two-Hearts
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Future

Comments

@akashsinghal
Copy link
Collaborator

What would you like to be added?

Ratify current requires the RATIFY_LOG_LEVEL feature flag to be set manually for debug logging. We should make this configurable via a flag in the CLI.

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@akashsinghal akashsinghal added enhancement New feature or request triage Needs investigation labels Nov 6, 2023
@FeynmanZhou
Copy link
Collaborator

This issue also relates to #1140

@yizha1 yizha1 removed the triage Needs investigation label Nov 7, 2023
@yizha1 yizha1 added this to the Future milestone Nov 7, 2023
@binbin-li binbin-li added the good first issue Good for newcomers label Nov 7, 2023
@Two-Hearts
Copy link
Contributor

If no one else is taking this one, I'd like to implement this. Thanks. @binbin-li

@Two-Hearts Two-Hearts mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Two-Hearts Two-Hearts

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

feat: add --debug flag to ratify CLI Two-Hearts/ratify
5 participants
@binbin-li @akashsinghal @FeynmanZhou @yizha1 @Two-Hearts