You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ratify was designed to load plugin configs from a mounted file to start up service without CRD support. But since we already have CRD support, maybe we can consider stop reading from the mounted config file.
The reason I want to remove it is that for each plugin config, Ratify might have 2 different set-up, one is from config file, the other is from CR objects. And if users delete all CR objects of a plugin, it will fall back to the config file which might beyond users' expection as deleting all CR objects means delete all related plugins.
If we remove the config file loading, Ratify would fully rely on the CRD resources and need not to select between config file and CR objects.
Anything else you would like to add?
No response
Are you willing to submit PRs to contribute to this feature?
Yes, I am willing to implement it.
The text was updated successfully, but these errors were encountered:
Agreed that having to keep track of which resource (CRD or configmap) overrides the other is very confusing. There are some fields that are only accessible in the CRD such as the executor config. Would we simply remove the overlapping config fields from the configmap and continue to use the same configmap but only for executor config? Or would we introduce another CRD?
Also, this wouldn't remove config file support for CLI scenarios right?
What would you like to be added?
Ratify was designed to load plugin configs from a mounted file to start up service without CRD support. But since we already have CRD support, maybe we can consider stop reading from the mounted config file.
The reason I want to remove it is that for each plugin config, Ratify might have 2 different set-up, one is from config file, the other is from CR objects. And if users delete all CR objects of a plugin, it will fall back to the config file which might beyond users' expection as deleting all CR objects means delete all related plugins.
If we remove the config file loading, Ratify would fully rely on the CRD resources and need not to select between config file and CR objects.
Anything else you would like to add?
No response
Are you willing to submit PRs to contribute to this feature?
The text was updated successfully, but these errors were encountered: