Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start server without plugin configs. #1104

Closed
1 task
binbin-li opened this issue Sep 28, 2023 · 1 comment · Fixed by #1223
Closed
1 task

Start server without plugin configs. #1104

binbin-li opened this issue Sep 28, 2023 · 1 comment · Fixed by #1223
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@binbin-li
Copy link
Collaborator

What would you like to be added?

Ratify was designed to load plugin configs from a mounted file to start up service without CRD support. But since we already have CRD support, maybe we can consider stop reading from the mounted config file.

The reason I want to remove it is that for each plugin config, Ratify might have 2 different set-up, one is from config file, the other is from CR objects. And if users delete all CR objects of a plugin, it will fall back to the config file which might beyond users' expection as deleting all CR objects means delete all related plugins.

If we remove the config file loading, Ratify would fully rely on the CRD resources and need not to select between config file and CR objects.

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@binbin-li binbin-li added enhancement New feature or request triage Needs investigation labels Sep 28, 2023
@akashsinghal
Copy link
Collaborator

Agreed that having to keep track of which resource (CRD or configmap) overrides the other is very confusing. There are some fields that are only accessible in the CRD such as the executor config. Would we simply remove the overlapping config fields from the configmap and continue to use the same configmap but only for executor config? Or would we introduce another CRD?

Also, this wouldn't remove config file support for CLI scenarios right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants