refactor!: make patch_style & reset_style chainable

[Valentin271]

Previously, patch_style and reset_style in Text, Line and Span were using a mutable reference to Self. To be more consistent with the rest of ratatui, which is using fluent setters, these now take ownership of Self and return it.

Closes #644

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc274e2) 92.3% compared to head (da5af28) 92.3%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #754     +/-   ##
=======================================
- Coverage   92.3%   92.3%   -0.1%     
=======================================
  Files         55      55             
  Lines      14831   14828      -3     
=======================================
- Hits       13694   13691      -3     
  Misses      1137    1137             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kdheepak]

I use .patch_style on a field in struct:

struct Config {
    calendar: Style
}

fn user_config() {
  // ...
  config.calendar.patch_style(Style::default().fg(color_from_user_input))
  // ...
}

I wouldn't be able to do this though if .patch_style takes an owned value.

[joshka]

calendar: Style

I wouldn't be able to do this though if .patch_style takes an owned value.

This doesn't change Style.patch_style, which already takes an owned value for the style parameter. Style implements Copy, so it doesn't really matter if it's owned.

I think maybe you're talking about not being able to do this on Lines/Spans that are stored?

[joshka]

Approved, but I want to make sure that @kdheepak's concern is addressed before merging.

[Valentin271]

Kind of messed up the rebase but its up to date now.

[kdheepak]

My bad, didn't review the code changes properly. I don't store Span in a struct, so this wouldn't be a problem for me. I'm assuming storing Span and then patching it is uncommon.

[joshka]

@Valentin271 the doc tests are failing.

[Valentin271]

I forgot to update the tests after the Line update.

I'd like another review on this because I modified the examples to be more concise and better demonstrate the effect. Before that the examples were the exact same as the tests.