feat: accept Color and Modifier for all Styles #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
======================================
Coverage 92.1% 92.1%
======================================
Files 48 48
Lines 14367 14511 +144
======================================
+ Hits 13238 13378 +140
- Misses 1129 1133 +4 ☔ View full report in Codecov by Sentry. |
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
kdheepak and
Valentin271
as code owners
|
PR Notes: this is a large-ish PR, but it's repetitive. It does have me wishing that we could macro up the setters though to remove the duplication. |
All style related methods now accept `S: Into<Style>` instead of
`Style`.
`Color` and `Modifier` implement `Into<Style>` so this is allows for
more ergonomic usage. E.g.:
```rust
Line::styled("hello", Style::new().red());
Line::styled("world", Style::new().bold());
// can now be simplified to
Line::styled("hello", Color::Red);
Line::styled("world", Modifier::BOLD);
```
Fixes #694
BREAKING CHANGE: All style related methods now accept `S: Into<Style>`
instead of `Style`. This means that if you are already passing an
ambiguous type that implements `Into<Style>` you will need to remove
the `.into()` call.
`Block` style methods can no longer be called from a const context as
trait functions cannot (yet) be const.
Adds conversions for various Color and Modifier combinations
|
Rebased on #721 to fix conflicts with the buffer module refactor. |
|
Fixed PR lint |
Valentin271
reviewed
Dec 30, 2023
Valentin271
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All style related methods now accept
S: Into<Style>instead ofStyle.ColorandModifierimplementInto<Style>so this is allows formore ergonomic usage. E.g.:
Fixes #694
BREAKING CHANGE: All style related methods now accept
S: Into<Style>instead of
Style. This means that if you are already passing anambiguous type that implements
Into<Style>you will need to removethe
.into()call.Blocks with styles can no longer be created in a const context astraits do not yet support const functions.