feat(line)!: add style field, setters and docs #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `Line` struct now stores the style of the line rather than each `Span` storing it. - Adds two new setters for style and spans - Adds missing docs BREAKING CHANGE: `Line::style` is now a field of `Line` instead of being stored in each `Span`.
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
kdheepak and
Valentin271
as code owners
github-actions
bot
added
the
Type: Breaking Change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
=======================================
+ Coverage 91.8% 92.0% +0.1%
=======================================
Files 42 42
Lines 13810 14023 +213
=======================================
+ Hits 12683 12902 +219
+ Misses 1127 1121 -6 ☔ View full report in Codecov by Sentry. |
Valentin271
reviewed
Dec 26, 2023
Valentin271
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linestruct now stores the style of the line rather than eachSpanstoring it.BREAKING CHANGE:
Line::styleis now a field ofLineinstead of beingstored in each
Span.