Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table)!: Add widths parameter to new() #664

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(table)!: Add widths parameter to new() #664

merged 1 commit into from
Dec 4, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Dec 4, 2023

  • style(tabs): fix doc formatting
  • feat(layout): Accept IntoIterator for constraints
  • fix(table)!: Add widths parameter to new()

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (91c67eb) 90.9% compared to head (50c2fa9) 90.8%.

Files Patch % Lines
src/widgets/table.rs 96.9% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #664     +/-   ##
=======================================
- Coverage   90.9%   90.8%   -0.1%     
=======================================
  Files         42      42             
  Lines      12502   12509      +7     
=======================================
- Hits       11373   11370      -3     
- Misses      1129    1139     +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka mentioned this pull request Dec 4, 2023
Closed
@joshka joshka changed the title table new widths fix(table)!: Add widths parameter to new() Dec 4, 2023
@github-actions github-actions bot added the Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc. label Dec 4, 2023
@orhun
Copy link
Member

orhun commented Dec 4, 2023

I'm guessing this depends on #663

@joshka joshka force-pushed the table-new-widths branch 2 times, most recently from a018446 to ee8bdc8 Compare December 4, 2023 18:47
@joshka
fix(table)!: Add widths parameter to new()
50c2fa9 
This prevents creating a table that doesn't actually render anything.

Fixes: #537

BREAKING CHANGE: Table::new() now takes an additional widths parameter.
@joshka joshka requested a review from Valentin271 as a code owner December 4, 2023 22:02
@joshka
Copy link
Member Author

joshka commented Dec 4, 2023

rebased on the other table changes

Valentin271
Valentin271 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@Valentin271 Valentin271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshka joshka merged commit 37c70db into main Dec 4, 2023
33 checks passed
@joshka joshka deleted the table-new-widths branch December 4, 2023 23:22
sarub0b0 added a commit to sarub0b0/kubetui that referenced this pull request Dec 29, 2023
@sarub0b0
fix(ui/table): ratatui/ratatui#664
ff8131a
This was referenced Jan 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valentin271 Valentin271 Valentin271 approved these changes

@orhun orhun orhun approved these changes

@mindoodoo mindoodoo Awaiting requested review from mindoodoo

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

@kdheepak kdheepak Awaiting requested review from kdheepak

Assignees
No one assigned
Labels
Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshka @orhun @Valentin271