fix(buffer): fix Debug panic and fix formatting of overridden parts #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJoPaTo
requested review from
orhun,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 61 61
Lines 14530 14538 +8
=====================================
+ Hits 13693 13701 +8
Misses 837 837 ☔ View full report in Codecov by Sentry. |
EdJoPaTo
commented
May 12, 2024
EdJoPaTo
commented
May 12, 2024
joshka
approved these changes
May 12, 2024
EdJoPaTo
changed the title
joshka
approved these changes
May 12, 2024
joshka
pushed a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
…atatui#1098) Fix panic in `Debug for Buffer` when `width == 0`. Also corrects the output when symbols are overridden.
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
…atatui#1098) Fix panic in `Debug for Buffer` when `width == 0`. Also corrects the output when symbols are overridden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panic in
Debug for Bufferwhenwidth == 0.Also corrects the output when symbols are overridden.
Let's do some final testing for #1007… test runner aborts on panic in panic handler. Nice. 👻