refactor(buffer): simplify set_stringn logic #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJoPaTo
requested review from
orhun,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
=======================================
+ Coverage 89.4% 94.1% +4.7%
=======================================
Files 61 61
Lines 15440 14619 -821
=======================================
- Hits 13808 13764 -44
+ Misses 1632 855 -777 ☔ View full report in Codecov by Sentry. |
joshka
reviewed
May 2, 2024
easier to read code due to less index assumptions
joshka
approved these changes
May 2, 2024
joshka
added a commit
that referenced
this pull request
May 5, 2024
This is a small universal style change to avoid making this change a part of other PRs. [rationale](#1083 (comment))
joshka
pushed a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
joshka
added a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
) This is a small universal style change to avoid making this change a part of other PRs. [rationale](ratatui#1083 (comment))
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
joshka
added a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
) This is a small universal style change to avoid making this change a part of other PRs. [rationale](ratatui#1083 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the logic. Instead of trying to figure out the
max_offsetin a seemingly complicated way keep theremaining_widthand count down as long as there are characters left. This is way easier to understand for me what is going on.Part of the improvements I did with #1049. As this is without
_optmethods this can still panic (same as current code on wrong input).