feat(constraints): Rename Constraint::Proportional to Constraint::Fill
#880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdheepak
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka and
Valentin271
as code owners
kdheepak
changed the title
Constraint::Proportional to Constraint::Fill
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
=======================================
- Coverage 92.2% 92.2% -0.1%
=======================================
Files 61 61
Lines 15981 15977 -4
=======================================
- Hits 14735 14731 -4
Misses 1246 1246 ☔ View full report in Codecov by Sentry. |
joshka
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraint::Fillis a more intuitive name for the behavior, and it is shorter.Resolves #859