refactor(colors_rgb): impl widget on mutable refs #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
kdheepak and
Valentin271
as code owners
orhun
approved these changes
Jan 24, 2024
Valentin271
approved these changes
Jan 24, 2024
This commit refactors the colors_rgb example to implement the Widget trait on mutable references to the app and its sub-widgets. This allows the app to update its state while it is being rendered. Additionally the main and run functions are refactored to be similar to the other recent examples. This uses a pattern where the App struct has a `run` method that takes a terminal as an argument, and the main function is in control of initizing and restoring the terminal and installing the error hooks.
joshka
force-pushed
the
refactor-colors-rgb
branch
from
1032348 to
629eedb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the colors_rgb example to implement the Widget
trait on mutable references to the app and its sub-widgets. This allows
the app to update its state while it is being rendered.
Additionally the main and run functions are refactored to be similar to
the other recent examples. This uses a pattern where the App struct has
a
runmethod that takes a terminal as an argument, and the mainfunction is in control of initizing and restoring the terminal and
installing the error hooks.