Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(symbols): add wide and tall proportional border set #848

Merged

Conversation

Emivvvvv
Copy link
Contributor

@Emivvvvv Emivvvvv commented Jan 18, 2024

Adds PROPORTIONAL_WIDE and PROPORTIONAL_TALL border sets.

symbols::border::PROPORTIONAL_WIDE

▄▄▄▄
█xx█
█xx█
▀▀▀▀

symbols::border::PROPORTIONAL_TALL

█▀▀█
█xx█
█xx█
█▄▄█

Fixes: #834

added proportional wide and tall set
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's convention to leave a blank line between the title of the comment and the body.

It would be nice to define proportional here as visually equal width and height.

I think the name is right.

Thanks for this.

@Emivvvvv
Copy link
Contributor Author

How about now? And you're welcome but I think I'm the one who should thank because you and the other maintainers are providing the best environment for open-source beginners like me :)

@joshka
Copy link
Member

joshka commented Jan 18, 2024

LGTM. Approving. Will wait on another maintainer to confirm the name makes sense to them as well.

@joshka
Copy link
Member

joshka commented Jan 19, 2024

Reformatted first comment for neater changelog.

@kdheepak
Copy link
Collaborator

I think the name is good, it has the same meaning to the naming in Padding. There's Contraints::Proportional that we might want to consider renaming to minimize confusion.

@joshka joshka merged commit 405a125 into ratatui:main Jan 19, 2024
42 checks passed
@orhun orhun changed the title feat: add wide and tall proportional border set feat(symbols): add wide and tall proportional border set Jan 19, 2024
@joshka
Copy link
Member

joshka commented Jan 19, 2024

Thanks for the PR @Emivvvvv :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wide and tall border set for half blocks
4 participants