-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(symbols): add wide and tall proportional border set #848
feat(symbols): add wide and tall proportional border set #848
Conversation
added proportional wide and tall set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's convention to leave a blank line between the title of the comment and the body.
It would be nice to define proportional here as visually equal width and height.
I think the name is right.
Thanks for this.
updated the documentation comments: ratatui#848 (review)
How about now? And you're welcome but I think I'm the one who should thank because you and the other maintainers are providing the best environment for open-source beginners like me :) |
LGTM. Approving. Will wait on another maintainer to confirm the name makes sense to them as well. |
Reformatted first comment for neater changelog. |
I think the name is good, it has the same meaning to the naming in |
Thanks for the PR @Emivvvvv :) |
Adds
PROPORTIONAL_WIDE
andPROPORTIONAL_TALL
border sets.symbols::border::PROPORTIONAL_WIDE
symbols::border::PROPORTIONAL_TALL
Fixes: #834