Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): document incompatible examples better #844

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

joshka
Copy link
Member

@joshka joshka commented Jan 18, 2024

Examples often take advantage of unreleased API changes, which makes them not copy-paste friendly.

Examples often take advantage of unreleased API changes, which makes them not copy-paste friendly.
Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshka joshka merged commit 41de884 into main Jan 18, 2024
32 checks passed
@joshka joshka deleted the examples-readme branch January 18, 2024 09:56
@joshka
Copy link
Member Author

joshka commented Jan 18, 2024

Merging this - we can do the other things in addition to this if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants