feat(table): deprecate SegmentSize on table #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new flex method with flex field Changed segment_size method to use flex method Deprecated segment_size method Removeed segment_size field Updated documentation
Emivvvvv
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
=====================================
Coverage 92.4% 92.4%
=====================================
Files 60 60
Lines 16185 16214 +29
=====================================
+ Hits 14966 14994 +28
- Misses 1219 1220 +1 ☔ View full report in Codecov by Sentry. |
kdheepak
reviewed
Jan 18, 2024
kdheepak
reviewed
Jan 18, 2024
kdheepak
reviewed
Jan 18, 2024
|
Thank you for the PR! |
orhun
reviewed
Jan 18, 2024
added since ="0.26.0" and changed note of the deprecated removed deprecated note from Table::segment_size method modified Table::flex doc to test the example
Valentin271
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #835
This PR adds:
for table
-test
fn underconstrained_segment_size()still uses segment_size to test if it still works.