-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(example): improve constraints and flex examples #817
Conversation
Looks great! Thanks for making the changes! |
Could it be worth putting the width bar at the top / bottom and compressing the examples into half as many lines? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
======================================
Coverage 92.4% 92.5%
======================================
Files 59 59
Lines 15616 15745 +129
======================================
+ Hits 14437 14571 +134
+ Misses 1179 1174 -5 ☔ View full report in Codecov by Sentry. |
Once this is merged I'll make a documentation PR to update the code snippets with this style. |
what about putting the pixels inside and the constraints on the border? |
What about the second option, but with centered headings? |
I considered it but in addition to what you said I also want something that is copy paste friendly, e.g.:
|
Copied...
|
This is the VHS size for 1200 pixels.
Lots of little things changed in those refactoring changes:
|
I like where this is going. I've just added some movement keybinding and adjusted the display on I think the only thing left is to reorder the code in |
Damn, that new |
@kdheepak was going to add comments to the examples. I think it could do with a ScrollBar as well. I'll reorder the constraints example to match flex, and add the ScrollBar shortly.
A joint effort of bouncing ideas back and forth with @kdheepak last night :) |
Alright. Agree for the scrollbar if you can make it work without too much hassle. I couldn't really because of the hacky way I implemented the scroll. |
Support multi-line comments Inverse tab colors
Co-authored-by: Josh McKinney <[email protected]>
Can we summarize this change in the first comment and then squash it? |
I've updated the PR description. This should be ready to squash. @joshka you want to do the honors? |
This PR is a follow up to #811.
It improves the UI of the layouts by
to name a few. Here are some example gifs of the outcome: