Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(terminal): extract types to files #760

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

joshka
Copy link
Member

@joshka joshka commented Jan 7, 2024

Fields on Frame that were private are now pub(crate).

Fields on Frame that were private are now pub(crate).
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (e64e194) 92.3% compared to head (70d43ff) 92.3%.

Files Patch % Lines
src/terminal/terminal.rs 90.9% 22 Missing ⚠️
src/terminal/frame.rs 65.2% 8 Missing ⚠️
src/terminal/viewport.rs 93.7% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #760   +/-   ##
=====================================
  Coverage   92.3%   92.3%           
=====================================
  Files         55      57    +2     
  Lines      14840   14840           
=====================================
  Hits       13703   13703           
  Misses      1137    1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Valentin271 Valentin271 merged commit 5aba988 into main Jan 7, 2024
@Valentin271 Valentin271 deleted the refactor-terminal branch January 7, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants