fix(table)!: ensure that default and new() match

[joshka]

In #660 we introduced the
segment_size field to the Table struct. However, we forgot to update
the default() implementation to match the new() implementation. This
meant that the default() implementation picked up SegmentSize::default()
instead of SegmentSize::None.

Additionally the introduction of Table::default() in an earlier PR,
#339, was also missing the
default for the column_spacing field (1).

This commit fixes the default() implementation to match the new()
implementation of these two fields by implementing the Default trait
manually.

BREAKING CHANGE: The default() implementation of Table now sets the
column_spacing field to 1 and the segment_size field to
SegmentSize::None. This will affect the rendering of a small amount of
apps.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0614190) 92.3% compared to head (63ea4c3) 92.3%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #751   +/-   ##
=====================================
  Coverage   92.3%   92.3%           
=====================================
  Files         57      57           
  Lines      14880   14916   +36     
=====================================
+ Hits       13746   13782   +36     
  Misses      1134    1134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshka]

Affected repos:
https://github.com/search?q=ratatui%20AND%20%22Table%3A%3Adefault()%22%20AND%20(NOT%20org%3Aratatui-org)%20AND%20NOT%20(is%3Afork)&type=code

• https://github.com/Adi-df/foucault - @Adi-df
• https://github.com/SOF3/lpl - @SOF3
• https://github.com/LAPKB/NPcore - @LAPKB
• https://github.com/sarub0b0/kubetui - @sarub0b0
• https://github.com/sadovsf/RadioLog - @sadovsf
• https://github.com/asomers/gstat-rs - @asomers

Note the suggested changes above.

The impact of this PR is that the column spacing will change unless you've manually specified this, and the last column will not fill the remaining space if your width constraints do not specify to do so.

Also note that segment_size is gated behind a feature flag (unstable-segment-size) if you need to use that.

[Adi-df]

Thanks for notifying the changes !

[joshka]

I'd like a second reviewer on this one before merging - mainly as a quick sanity check that this breaking change makes sense.

[Valentin271]

Makes sense to me, approved.

[orhun]

LGTM

[joshka]

Resolved conflicts in BREAKING-CHANGES.md

[kdheepak]

It was because this PR wasn't rebased on the latest main. I thought GitHub's queue feature would catch this but that doesn't seem to be the case?

[joshka]

Squash doesn't do a rebase, CI, then merge. it just does the rebase, merge part. The changes were textually non conflicting, just semantically.

[asomers]

Thanks for notifying. But FTR, the warning for gstat-rs is a false alarm.