feat(layout): accept Into<Constraint> for constructors #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
=======================================
- Coverage 92.3% 92.3% -0.1%
=======================================
Files 52 52
Lines 14806 14811 +5
=======================================
+ Hits 13672 13674 +2
- Misses 1134 1137 +3 ☔ View full report in Codecov by Sentry. |
joshka
force-pushed
the
layout-accept-into-constraint
branch
from
a5abefe to
289ec88
Compare
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
kdheepak and
Valentin271
as code owners
kdheepak
approved these changes
Jan 5, 2024
This allows Layout constructors to accept any type that implements Into<Constraint> instead of just AsRef<Constraint>. This is useful when you want to specify a fixed size for a layout, but don't want to explicitly create a Constraint::Length yourself. ```rust Layout::new(Direction::Vertical, [1, 2, 3]); Layout::horizontal([1, 2, 3]); Layout::vertical([1, 2, 3]); Layout::default().constraints([1, 2, 3]); ```
joshka
force-pushed
the
layout-accept-into-constraint
branch
from
289ec88 to
e5033b8
Compare
|
@a-kenji feel free to provide feedback on what you think about this PR, even if it is merged! We'd definitely want to hear everyone's opinions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Layout constructors to accept any type that implements
Into instead of just AsRef. This is useful when
you want to specify a fixed size for a layout, but don't want to
explicitly create a Constraint::Length yourself.