Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(termwiz): add From termwiz style impls #726

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

Valentin271
Copy link
Member

@Valentin271 Valentin271 commented Jan 2, 2024

Closes #679

Important note: this also fixes a wrong mapping between ratatui's gray and termwiz's grey. ratatui::Color::Gray now maps to termwiz::color::AnsiColor::Silver

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8f56fab) 92.1% compared to head (6b43e35) 92.3%.

Files Patch % Lines
src/backend/termwiz.rs 99.2% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #726     +/-   ##
=======================================
+ Coverage   92.1%   92.3%   +0.1%     
=======================================
  Files         48      48             
  Lines      14511   14769    +258     
=======================================
+ Hits       13378   13635    +257     
- Misses      1133    1134      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though when merging this make sure to document the color change for the changelog.

@joshka joshka merged commit b459228 into ratatui:main Jan 2, 2024
@Valentin271 Valentin271 deleted the feat/from-termwiz-color branch January 3, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement From for Style
2 participants