feat(layout): allow layout fill to be configurable #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit and
kdheepak
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
=====================================
Coverage 90.4% 90.4%
=====================================
Files 41 41
Lines 11907 11907
=====================================
Hits 10775 10775
Misses 1132 1132 ☔ View full report in Codecov by Sentry. |
The layout split will generally fill the remaining area when `split()` is called. This change allows the caller to configure how any extra space is allocated to the `Rect`s. This is useful for cases where the caller wants to have a fixed size for one of the `Rect`s, and have the other `Rect`s fill the remaining space. For now, the method and enum are marked as unstable because the exact name is still being bikeshedded. To enable this functionality, add the `unstable-segment-size` feature flag in your `Cargo.toml`. To configure the layout to fill the remaining space evenly, use `Layout::segment_size(SegmentSize::EvenDistribution)`. The default behavior is `SegmentSize::LastTakesRemainder`, which gives the last segment the remaining space. `SegmentSize::None` will disable this behavior. See the docs for `Layout::segment_size()` and `layout::SegmentSize` for more information. Fixes #536
joshka
force-pushed
the
segment-experimental
branch
from
430d420 to
a22a9f1
Compare
|
Updated commit message to work better in the changelog |
orhun
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(layout): allow configuring layout fill
The layout split will generally fill the remaining area when
split()is called. This change allows the caller to configure how any extra
space is allocated to the
Rects. This is useful for cases where thecaller wants to have a fixed size for one of the
Rects, and have theother
Rects fill the remaining space.For now, the method and enum are marked as unstable because the exact
name is still being bikeshedded. To enable this functionality, add the
unstable-segment-sizefeature flag in yourCargo.toml.To configure the layout to fill the remaining space evenly, use
Layout::segment_size(SegmentSize::EvenDistribution). The defaultbehavior is
SegmentSize::LastTakesRemainder, which gives the lastsegment the remaining space.
SegmentSize::Nonewill disable thisbehavior. See the docs for
Layout::segment_size()andlayout::SegmentSizefor more information.Method docs:
Type docs:
Note: I fixed the link to the
Tablewidget - just didn't re-screenshot.