Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): support line alignment #599

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Conversation

orhun
Copy link
Member

@orhun orhun commented Oct 27, 2023

related: #257

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18e19f6) 90.5% compared to head (f247e48) 90.7%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #599     +/-   ##
=======================================
+ Coverage   90.5%   90.7%   +0.1%     
=======================================
  Files         41      41             
  Lines      11980   12130    +150     
=======================================
+ Hits       10853   11003    +150     
  Misses      1127    1127             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this probably is missing some unit tests, docs, and breaking changes notes

src/widgets/list.rs Show resolved Hide resolved
src/widgets/list.rs Show resolved Hide resolved
@orhun orhun requested a review from joshka November 23, 2023 10:06
@orhun
Copy link
Member Author

orhun commented Nov 23, 2023

Not sure if this is a breaking change but will update the docs after I figure out the test failure.

src/widgets/list.rs Outdated Show resolved Hide resolved
@joshka joshka merged commit c862aa5 into ratatui:main Nov 23, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants