refactor(widgets): remove unnecessary dynamic dispatch and heap allocation #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka and
kdheepak
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
=====================================
Coverage 90.5% 90.5%
=====================================
Files 41 41
Lines 11978 11980 +2
=====================================
+ Hits 10850 10853 +3
+ Misses 1128 1127 -1 ☔ View full report in Codecov by Sentry. |
joshka
approved these changes
Nov 21, 2023
…ation Signed-off-by: rhysd <[email protected]>
rhysd
force-pushed
the
refactor-render-paragraph
branch
from
83acf66 to
3f76164
Compare
joshka
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors implementation of
Paragraph::render. It allocatesLineComposertrait object on heap memory and calls its methods via dynamic dispatch. However it can be easily changed to static dispatch with allocating the object on stack.This PR does the change as refactoring. No rendering logic has changed.