fix(gauge): fix gauge widget colors #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The background colors of the gauge had a workaround for the issue we had with VHS / TTYD rendering the background color of the gauge. This workaround is no longer necessary in the updated versions of VHS / TTYD. Fixes #501
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles and
kdheepak
as code owners
|
|
|
Ping @LeoniePhiline Can you please test this in your application using a patch override in your cargo.toml: [patch.crates-io]
ratatui = { git = "https://github.com/ratatui-org/ratatui.git", branch = "fix-gauge" }Note that if you're using the non-alpha version of ratatui there may be a few other unreleased breaking changes. See https://github.com/ratatui-org/ratatui/blob/main/BREAKING-CHANGES.md for more details. |
Codecov Report
@@ Coverage Diff @@
## main #572 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 41 41
Lines 11557 11557
=======================================
Hits 10345 10345
Misses 1212 1212
|
|
Thanks for pinging me! Unfortunately I'm currently ill and cannot perform any tests. |
No problem - get well soon |
kdheepak
approved these changes
Oct 19, 2023
IlyaSelivanov
pushed a commit
to IlyaSelivanov/ratatui
that referenced
this pull request
Oct 19, 2023
The background colors of the gauge had a workaround for the issue we had with VHS / TTYD rendering the background color of the gauge. This workaround is no longer necessary in the updated versions of VHS / TTYD. Fixes ratatui#501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background colors of the gauge had a workaround for the issue we had
with VHS / TTYD rendering the background color of the gauge. This
workaround is no longer necessary in the updated versions of VHS / TTYD.
Fixes #501