Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add buffer_mut method on Frame #548

Merged
merged 1 commit into from
Sep 30, 2023
Merged

feat: Add buffer_mut method on Frame #548

merged 1 commit into from
Sep 30, 2023

Conversation

kdheepak
Copy link
Collaborator

current_buffer_mut already exists on Terminal. It would be nice to expose the same thing to Frame as well.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #548 (1a16fc4) into main (11076d0) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   89.65%   89.63%   -0.03%     
==========================================
  Files          41       41              
  Lines       11437    11440       +3     
==========================================
  Hits        10254    10254              
- Misses       1183     1186       +3     
Files Coverage Δ
src/terminal.rs 57.79% <0.00%> (-0.67%) ⬇️

src/terminal.rs Outdated Show resolved Hide resolved
@joshka
Copy link
Member

joshka commented Sep 29, 2023

I think this is a good idea - as it enables working with the frame in sub functions (e.g. things like components).
Let's wait for a second review by one of the other maintainers on this though.

@kdheepak kdheepak force-pushed the kd/current-buffer-mut branch from b1d39f2 to 1a16fc4 Compare September 29, 2023 11:28
@kdheepak kdheepak changed the title feat: Add current_buffer_mut method on Frame feat: Add buffer_mut method on Frame Sep 29, 2023
@joshka joshka added this to the v0.24.0 milestone Sep 29, 2023
@joshka joshka merged commit 15641c8 into main Sep 30, 2023
34 of 36 checks passed
@kdheepak kdheepak deleted the kd/current-buffer-mut branch September 30, 2023 12:56
tonogdlp pushed a commit to tonogdlp/ratatui that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants