refactor(barchart): replace remove_invisible_groups_and_bars by group… #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthago1
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 89.65% 89.51% -0.15%
==========================================
Files 41 41
Lines 11437 11451 +14
==========================================
- Hits 10254 10250 -4
- Misses 1183 1201 +18
|
karthago1
force-pushed
the
hich/barchart-refactor
branch
2 times, most recently
from
2d9e609 to
5b901e3
Compare
|
also I noticed, that I should replace the removed unit tests in the previous commit. (I almost made some breaking changes) |
joshka
approved these changes
Sep 28, 2023
karthago1
force-pushed
the
hich/barchart-refactor
branch
from
5b901e3 to
c8dd9cc
Compare
…_ticks group_ticks calculates the visible bar length in ticks. (A cell contains 8 ticks). It is used for 2 purposes: 1. to get the bar length in ticks for rendering 2. since it delivers only the values of the visible bars, If we zip these values with the groups and bars, then we will filter out the invisible groups and bars Signed-off-by: Ben Fekih, Hichem <[email protected]>
karthago1
force-pushed
the
hich/barchart-refactor
branch
from
c8dd9cc to
c3b372f
Compare
joshka
approved these changes
Sep 29, 2023
|
Thanks for the PR |
tonogdlp
pushed a commit
to tonogdlp/ratatui
that referenced
this pull request
Oct 6, 2023
Replace `remove_invisible_groups_and_bars` with `group_ticks` `group_ticks` calculates the visible bar length in ticks. (A cell contains 8 ticks). It is used for 2 purposes: 1. to get the bar length in ticks for rendering 2. since it delivers only the values of the visible bars, If we zip these values with the groups and bars, then we will filter out the invisible groups and bars Signed-off-by: Ben Fekih, Hichem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is maybe still not what you expect. but maybe it is a small step. (At least the internal state is not changed)
remove_invisible_groups_and_bars()is replaced bygroup_ticks(), which calculates the visible bar length in ticks. (A cell contains 8 ticks).It is used for 2 purposes:
Since this patch, doesn't add any new feature, it can be closed, if it doesn't add any value regarding readability.