Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tabs): add documentation to Tabs #535

Merged
merged 1 commit into from
Sep 26, 2023
Merged

docs(tabs): add documentation to Tabs #535

merged 1 commit into from
Sep 26, 2023

Conversation

Valentin271
Copy link
Member

Screenshot

image

@Valentin271 Valentin271 mentioned this pull request Sep 25, 2023
Closed
9 tasks
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #535 (1906f28) into main (32e4619) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   89.94%   89.95%           
=======================================
  Files          40       41    +1     
  Lines       11337    11347   +10     
=======================================
+ Hits        10197    10207   +10     
  Misses       1140     1140
Files Coverage Δ
src/widgets/tabs.rs 85.51% <ø> (ø)

... and 3 files with indirect coverage changes

joshka
joshka approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to take with / without the suggested change - let me know what you think.

@joshka joshka merged commit 3bda372 into ratatui:main Sep 26, 2023
@Valentin271 Valentin271 deleted the docs/tabs branch September 26, 2023 06:36
tonogdlp pushed a commit to tonogdlp/ratatui that referenced this pull request Oct 6, 2023
@Valentin271
docs(tabs): add documentation to Tabs (ratatui#535)
90b05a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

@orhun orhun orhun approved these changes

@mindoodoo mindoodoo Awaiting requested review from mindoodoo

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

@sophacles sophacles Awaiting requested review from sophacles

@kdheepak kdheepak Awaiting requested review from kdheepak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Valentin271 @joshka @orhun