Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make library and README consistent #526

Merged
merged 2 commits into from
Sep 28, 2023
Merged

docs: make library and README consistent #526

merged 2 commits into from
Sep 28, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Sep 21, 2023

Generate the bulk of the README from the library documentation, so that
they are consistent using cargo-rdme.

  • Removed the Contributors section, as it is redundant with the
    github contributors list.
  • Removed the info about the other backends and replaced it with a
    pointer to the documentation.

Fixes: #512

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #526 (5e34a05) into main (301366c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files          41       41           
  Lines       11437    11437           
=======================================
  Hits        10254    10254           
  Misses       1183     1183           

@joshka
Copy link
Member Author

joshka commented Sep 21, 2023

Outdated

Screen Shot 2023-09-22 at 04 12 51

@joshka
Copy link
Member Author

joshka commented Sep 21, 2023

ping @1oglop1

README.md Outdated Show resolved Hide resolved
@joshka joshka changed the base branch from main to feat-frame-remove-generic September 23, 2023 00:07
@joshka
Copy link
Member Author

joshka commented Sep 23, 2023

With discussed tweaks (rebased on the frame PR):
Screen Shot 2023-09-22 at 17 08 43

README.md Outdated Show resolved Hide resolved
kdheepak
kdheepak previously approved these changes Sep 23, 2023
Base automatically changed from feat-frame-remove-generic to main September 26, 2023 05:30
@joshka joshka dismissed kdheepak’s stale review September 26, 2023 05:30

The base branch was changed.

@joshka joshka force-pushed the cargo-rdme branch 2 times, most recently from 5460ac5 to 4e5f4d9 Compare September 26, 2023 22:09
Generate the bulk of the README from the library documentation, so that
they are consistent using cargo-rdme.

- Removed the Contributors section, as it is redundant with the github
  contributors list.
- Removed the info about the other backends and replaced it with a
  pointer to the documentation.
- add docsrs example, vhs tape and images that will end up in the README

Fixes: #512
@joshka
Copy link
Member Author

joshka commented Sep 26, 2023

Rebased to address lib.rs conflicts, squashed and updated commit message.

@joshka joshka merged commit c0991cc into main Sep 28, 2023
33 checks passed
@joshka joshka deleted the cargo-rdme branch September 28, 2023 02:57
tonogdlp pushed a commit to tonogdlp/ratatui that referenced this pull request Oct 6, 2023
* docs: make library and README consistent

Generate the bulk of the README from the library documentation, so that
they are consistent using cargo-rdme.

- Removed the Contributors section, as it is redundant with the github
  contributors list.
- Removed the info about the other backends and replaced it with a
  pointer to the documentation.
- add docsrs example, vhs tape and images that will end up in the README

Fixes: ratatui#512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs - landing page Layout section is out of place -> not newcomer friendly
2 participants