docs: import prelude::* in doc examples #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #490 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 41 41
Lines 11277 11277
=======================================
Hits 10168 10168
Misses 1109 1109
|
joshka
force-pushed
the
docs-prelude
branch
from
69211ce to
efb7a40
Compare
kdheepak
reviewed
Sep 11, 2023
kdheepak
approved these changes
Sep 11, 2023
joshka
force-pushed
the
docs-prelude
branch
from
efb7a40 to
e57405b
Compare
This commit adds `prelude::*` all doc examples and widget::* to those that need it. This is done to highlight the use of the prelude and simplify the examples. - Examples in Type and module level comments show all imports and use `prelude::*` and `widget::*` where possible. - Function level comments hide imports unless there are imports other than `prelude::*` and `widget::*`.
|
Rebased on the other doc changes to fix conflicts |
joshka
force-pushed
the
docs-prelude
branch
from
e57405b to
206300d
Compare
kdheepak
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
prelude::*all doc examples and widget::* to thosethat need it. This is done to highlight the use of the prelude and
simplify the examples.
prelude::*andwidget::*where possible.than
prelude::*andwidget::*.Fixes #448 by ensuring that module and type level code always contains all the imports required to compile the example.