Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a check for if breaking change label should be added #481

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

kdheepak
Copy link
Collaborator

@kdheepak kdheepak commented Sep 10, 2023

This PR will do 3 things

  1. Add a comment if the title is not in conventional commit specification, urging the PR submitter to change it
  2. Remove the comment if the title is updated
  3. Add a breaking change label if the title has a !: in it and follows the conventional commit specification.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #481 (88be3f2) into main (17797d8) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files          41       41           
  Lines       11277    11277           
=======================================
  Hits        10168    10168           
  Misses       1109     1109           

@kdheepak kdheepak force-pushed the breaking-change-workflow branch from 21d40a2 to 88be3f2 Compare September 10, 2023 00:33
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@kdheepak kdheepak merged commit 384e616 into ratatui:main Sep 10, 2023
30 of 31 checks passed
@kdheepak kdheepak deleted the breaking-change-workflow branch September 10, 2023 01:06
@orhun
Copy link
Member

orhun commented Sep 10, 2023

Hey, I'm curious how did you test this? Is there an example PR at somewhere else?

@kdheepak
Copy link
Collaborator Author

Here's where I tested it: #482. If you want to try it you can restore branch and reopen the PR. I also have a personal repo where I did tests that I can share if you'd like.

@orhun
Copy link
Member

orhun commented Sep 10, 2023

Got it, thanks for sharing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants