-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): add colors_rgb example #476
Conversation
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 40 41 +1
Lines 11166 11166
=======================================
Hits 10057 10057
Misses 1109 1109 |
Do you think this should just be a separate demo? |
Yes probably. I wasn't sure about it myself, so just went with adding code, but it wouldn't hurt. |
Works great! It isn't really intuitive from the demo so I'd also say that we should have this as a separate example. |
a32f935
to
dd14a51
Compare
I tweaked a bunch of stuff in the updated example:
|
369cb41
to
a38b3c6
Compare
|
a38b3c6
to
37f0194
Compare
moved the init/restore/panic hook to the bottom of the file to make the example really hyper focus on the application logic and example rather than the generic terminal parts. |
Helpful for diagnosing what's happening with #475