-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Block): add documentation to Block #469
Conversation
Codecov Report
@@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 90.00% 90.06% +0.06%
==========================================
Files 40 40
Lines 11156 11166 +10
==========================================
+ Hits 10041 10057 +16
+ Misses 1115 1109 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I've marked the PR as approved, and we can merge it as-is, but I'd also be happy to keep this open to take whatever changes you see as useful based on the feedback below.
I have lots of little comments on this, but none of them are super important / blocking, so please read them as discussion points.
add documentation to the `Block` widget and its sub-components
2614e2a
to
5856bdf
Compare
I fixed most of your comments. I just left out the comments about the style and style prioritization. I agree that we should use a consistent language and document the style priorities. But I think this would be better documented in the As for the consistent language, we could add to the guideline, for example:
Put in other words, some sort of template. |
Thanks - I'll slap together a PR that fixes up the remaining wording for styles. |
I removed the commit message body, as I don't think it really added much info to the changelog that wouldn't be answered by reading the commit title. |
Add documentation to the
Block
widget and its sub-components (Padding
,Borders
).Relates to #386