-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(paragraph): added documentation to the "alignment" method #467
Conversation
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 40 40
Lines 11156 11156
=======================================
Hits 10041 10041
Misses 1115 1115
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix this up rather than creating a new PR, you can rebase and squash the commits:
git rebase -i
change the second "pick" to "fixup" (or just "f"), save and close
git push origin main
I've resolved all suggested changes. Although the following error kept popping up:
I pushed with the '--no-verify' flag |
Apologies - I just accidentally pushed the main branch over your main branch rather than my local copy of your main branch rebased to your main branch (which closes the PR and locks me out of the branch), so this shows as closed. I've merged it out of band to fix things up however). Thanks for your first contribution to ratatui! |
Ayyyyy! 🚀🚀🚀🚀🚀 |
Added documentation to the
alignment
method of theParagraph
widget.This is really just 1 commit, the second commit was made because the first wasn't signed