Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): move formatting and doc checks first #465

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Conversation

joshka
Copy link
Member

@joshka joshka commented Sep 2, 2023

Putting the formatting and doc checks first to ensure that more critical
errors are caught first (e.g. a conventional commit error or typo should
not prevent the formatting and doc checks from running).

See https://github.com/ratatui-org/ratatui/actions/runs/6058985586/job/16441639521?pr=462:

image

Putting the formatting and doc checks first to ensure that more critical
errors are caught first (e.g. a conventional commit error or typo should
not prevent the formatting and doc checks from running).
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #465 (205587f) into main (5c785b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          40       40           
  Lines       11156    11156           
=======================================
  Hits        10041    10041           
  Misses       1115     1115           

@orhun orhun merged commit 343c6cd into ratatui:main Sep 2, 2023
@joshka joshka deleted the ci-lint branch September 3, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants