fix(chart): fix chart row style being incorrect when using Axis::title

[aatukaj]

Fixes: #379

old behavior

new fixed

[codecov]

Codecov Report

Merging #462 (b22a249) into main (e098731) will increase coverage by 0.06%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head b22a249 differs from pull request most recent head 2341fb6. Consider uploading reports for the commit 2341fb6 to get more accurate results

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   90.00%   90.06%   +0.06%     
==========================================
  Files          40       40              
  Lines       11156    11166      +10     
==========================================
+ Hits        10041    10057      +16     
+ Misses       1115     1109       -6     

Files Changed	Coverage Δ
src/widgets/chart.rs	98.52% <100.00%> (+0.67%)	⬆️

... and 1 file with indirect coverage changes

[aatukaj]

I'm not really sure on how to go about fixing that commit lint :(

[joshka]

I'm not really sure on how to go about fixing that commit lint :(

Mainly this would be fixed by changing the word "added" to "add"
In this case, I'll squash the two commits during the merge, and add some context to the commit message body, as the additional test really is part of the main change and doesn't really need a separate commit.

[joshka]

Actually - change of plans, double checking this locally, the conventional commit lint prevented the formatting check to run, and there's an extraneous newline that the formatter corrects. Can you please squash the two commits using git rebase and then run cargo +nightly fmt --all and force push the result to your github branch (git push origin main --force)?

Do you think it would be worth adding another unit test that also checks that the data style is not overwritten by the title / axis style?

Here's a suggestion for an improved commit message. I'm not sure if I've correctly noted that it's the dataset style not the title style here.

fix(chart): use graph style for top line

A bug in the rendering caused the top line of the chart to be rendered
using the style of the Y Axis, instead of the dataset style. This is
fixed by only setting the style for the width of the text, and not the
entire row.

Fixes: https://github.com/ratatui-org/ratatui/issues/379

[joshka]

Actually - change of plans, double checking this locally, the conventional commit lint prevented the formatting check to run, and there's an extraneous newline that the formatter corrects. Can you please squash the two commits using git rebase and then run cargo +nightly fmt --all and force push the result to your github branch (git push origin main --force)?

Do you think it would be worth adding another unit test that also checks that the data style is not overwritten by the title / axis style?

Here's a suggestion for an improved commit message. I'm not sure if I've correctly noted that it's the dataset style not the title style here.

fix(chart): use graph style for top line

A bug in the rendering caused the top line of the chart to be rendered
using the style of the Y Axis, instead of the dataset style. This is
fixed by only setting the style for the width of the text, and not the
entire row.

Fixes: https://github.com/ratatui-org/ratatui/issues/379

[aatukaj]

Added the test. Hopefully I did the rebase correctly. Thanks for the commit suggestion.

[joshka]

Thanks for adding the test. LGTM. One last thing (unless the other maintainers have comments on the PR):

We use commit signature verification, which will block commits from being merged unless they are signed. To set up your machine to sign commits, see managing commit signature verification in GitHub docs.

Also not a big deal, the commit message doesn't really need the following lines as writing tests can be generally considered as part of a feature:

test(chart): add test for too big titles
test(chart): add test for correct top line styling

[aatukaj]

Everything should be good now.
Thanks for all the help!