Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add descriptions and update theme #460

Closed
wants to merge 3 commits into from

Conversation

joshka
Copy link
Member

@joshka joshka commented Sep 2, 2023

Fixes #401

  • docs(examples): add descriptions and update theme
    Use the OceanicMaterial consistently in examples

  • docs(examples): move example gifs to github
    A new orphan branch named "images" is created to store the example images

See https://github.com/ratatui-org/ratatui/tree/images

Use the OceanicMaterial consistently in examples
A new orphan branch named "images" is created to store the example images
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #460 (c623cc8) into main (0696f48) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is n/a.

❗ Current head c623cc8 differs from pull request most recent head bb14d77. Consider uploading reports for the commit bb14d77 to get more accurate results

@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          40       40           
  Lines       11156    11156           
=======================================
  Hits        10041    10041           
  Misses       1115     1115           

Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we also auto-generate GIFs on that branch?

@joshka
Copy link
Member Author

joshka commented Sep 2, 2023

Definitely worth doing sometime, but there doesn't seem to be an easy way to only generate the gif that has changed, so manual works for the short term.

joshka added a commit to joshka/ratatui that referenced this pull request Sep 2, 2023
- Use the OceanicMaterial consistently in examples
joshka added a commit to joshka/ratatui that referenced this pull request Sep 2, 2023
- A new orphan branch named "images" is created to store the example
  images
@joshka joshka closed this Sep 2, 2023
@joshka joshka deleted the docs-readme branch September 2, 2023 21:22
@orhun
Copy link
Member

orhun commented Sep 5, 2023

Uhm, why this was closed?

@joshka
Copy link
Member Author

joshka commented Sep 5, 2023

We were modifying the merge settings at the time (as rebasing doesn't work with signed commits), and I merged this manually (so the two commits would be separate rather than squashed).
Just joshka@ca9bcd3 and joshka@5c785b2 are merged (not the extraneous bb14d77)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all demo gifs to github
2 participants