-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): add descriptions and update theme #460
Conversation
Use the OceanicMaterial consistently in examples
A new orphan branch named "images" is created to store the example images
Codecov Report
@@ Coverage Diff @@
## main #460 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 40 40
Lines 11156 11156
=======================================
Hits 10041 10041
Misses 1115 1115 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should we also auto-generate GIFs on that branch?
Definitely worth doing sometime, but there doesn't seem to be an easy way to only generate the gif that has changed, so manual works for the short term. |
- Use the OceanicMaterial consistently in examples
- A new orphan branch named "images" is created to store the example images
Uhm, why this was closed? |
We were modifying the merge settings at the time (as rebasing doesn't work with signed commits), and I merged this manually (so the two commits would be separate rather than squashed). |
Fixes #401
docs(examples): add descriptions and update theme
Use the OceanicMaterial consistently in examples
docs(examples): move example gifs to github
A new orphan branch named "images" is created to store the example images
See https://github.com/ratatui-org/ratatui/tree/images