Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Check that PR title matches conventional commit guidelines #459

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

kdheepak
Copy link
Collaborator

@kdheepak kdheepak commented Sep 1, 2023

This runs a quick check to see if the PR title matches conventions commit guidelines. This action reruns if the title is edited and modified.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #459 (caef532) into main (878b6fc) will not change coverage.
The diff coverage is n/a.

❗ Current head caef532 differs from pull request most recent head 1b1c245. Consider uploading reports for the commit 1b1c245 to get more accurate results

@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          40       40           
  Lines       11156    11156           
=======================================
  Hits        10041    10041           
  Misses       1115     1115           

@a-kenji
Copy link
Contributor

a-kenji commented Sep 1, 2023

I assumed the committed check does that already. Is that incorrect?

Copy link
Member

@mindoodoo mindoodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-kenji Unfortunately not :/

Thanks kd !

.github/workflows/check-pr-title.yml Outdated Show resolved Hide resolved
@joshka
Copy link
Member

joshka commented Sep 2, 2023

Let's squash this and then merge.

@kdheepak kdheepak force-pushed the check-pr-title branch 2 times, most recently from 6f2ee7a to 2503283 Compare September 2, 2023 01:01
@kdheepak kdheepak added this pull request to the merge queue Sep 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Sep 2, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@joshka joshka added this pull request to the merge queue Sep 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Sep 2, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@joshka joshka force-pushed the check-pr-title branch 2 times, most recently from 4220c8a to aea9600 Compare September 2, 2023 02:53
@joshka joshka merged commit 47ae602 into ratatui:main Sep 2, 2023
@kdheepak kdheepak deleted the check-pr-title branch September 2, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants