Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(barchart): add benchmarks #455

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

Valentin271
Copy link
Member

@Valentin271 Valentin271 commented Aug 30, 2023

Adds benchmarks for the BarChart widget.

Relates to #137.

Here is the resulting graph.
image

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #455 (16f11fa) into main (927a5d8) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   90.03%   90.00%   -0.03%     
==========================================
  Files          40       40              
  Lines       11127    11156      +29     
==========================================
+ Hits        10018    10041      +23     
- Misses       1109     1115       +6     

see 2 files with indirect coverage changes

Copy link
Contributor

@karthago1 karthago1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the measurements, I always wondered how fast is the rendering.

benches/barchart.rs Show resolved Hide resolved
benches/barchart.rs Show resolved Hide resolved
benches/barchart.rs Show resolved Hide resolved
@joshka joshka added this pull request to the merge queue Sep 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Sep 1, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@joshka joshka added this pull request to the merge queue Sep 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Sep 2, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@joshka joshka merged commit ea70bff into ratatui:main Sep 2, 2023
@Valentin271 Valentin271 deleted the test/barchart-bench branch September 2, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants