Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix documentation lint warnings #450

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

Valentin271
Copy link
Member

I just fixed some doc lint warning that were annoying while documenting as they prevented the switch to the doc job.

I don't see any documentation build test in cargo make ci, we probably should add it to avoid documentation mistakes?

Lint errors for `doc-open` job

image

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #450 (f7326f4) into main (28c6157) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files          40       40           
  Lines       11127    11127           
=======================================
  Hits        10018    10018           
  Misses       1109     1109           
Files Changed Coverage Δ
src/backend/mod.rs 82.92% <ø> (ø)
src/style.rs 93.38% <ø> (ø)
src/widgets/calendar.rs 81.06% <ø> (ø)

@orhun
Copy link
Member

orhun commented Aug 30, 2023

I don't see any documentation build test in cargo make ci, we probably should add it to avoid documentation mistakes?

That'd be nice!

@Valentin271
Copy link
Member Author

I'll open an issue to track this then.

@orhun orhun added this pull request to the merge queue Aug 30, 2023
Merged via the queue into ratatui:main with commit 927a5d8 Aug 30, 2023
@Valentin271 Valentin271 deleted the docs/lint branch August 30, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants