-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to use ratatui #446
Conversation
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 40 40
Lines 11079 11079
=======================================
Hits 10018 10018
Misses 1061 1061 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 too
@kdheepak looks like your gpg signing was broken. Pushing a rebase should in theory allow this to merge. |
Thanks for catching that! It looks like I'll need to set up a post-commit gpg signing check :) |
In my opinion, this change in the docs will be a better user experience for most people, for the following reasons:
tui
:At best, we should only recommend this:
But I think we should save that for the docs or the ratatui-book; and the README should have one obvious way for newcomers to add the
ratatui
crate to their project.Third party crates linked have migrated from
tui
toratatui
.If users use
ratatui
explicitly in the code, it'll will allow for searching forratatui
on github / gitlab etc to be easier going forward.