Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(project): make the project description cooler #441

Merged
merged 2 commits into from
Aug 27, 2023
Merged

docs(project): make the project description cooler #441

merged 2 commits into from
Aug 27, 2023

Conversation

orhun
Copy link
Member

@orhun orhun commented Aug 27, 2023

😎

@orhun
Copy link
Member Author

orhun commented Aug 27, 2023

I don't know if we should remove "dashboards" and simplify the description. Whachu y'all think?

joshka
joshka approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL Yes

@codecov
Copy link

codecov bot commented Aug 27, 2023 •
edited
Loading

Codecov Report

Merging #441 (f86012b) into main (e9bd736) will increase coverage by 0.08%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   90.34%   90.42%   +0.08%     
==========================================
  Files          40       40              
  Lines       10977    11081     +104     
==========================================
+ Hits         9917    10020     +103     
- Misses       1060     1061       +1

see 1 file with indirect coverage changes

mindoodoo
mindoodoo approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@mindoodoo mindoodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we should remove "dashboards" and simplify the description. Whachu y'all think?

Yup, otherwise this is awesome 🚀

@orhun orhun enabled auto-merge August 27, 2023 10:45
@orhun orhun added this pull request to the merge queue Aug 27, 2023
Merged via the queue into ratatui:main with commit 47fe4ad Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindoodoo mindoodoo mindoodoo approved these changes

@joshka joshka joshka approved these changes

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

@sophacles sophacles Awaiting requested review from sophacles

@kdheepak kdheepak Awaiting requested review from kdheepak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orhun @joshka @mindoodoo