Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(traits): add Display and FromStr traits #425

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Aug 22, 2023

Use strum for most of these, with a couple of manual implementations, and
related tests

Fixes #307

note: this is mainly the enums, the structs tend not to have obvious display representations.

ping @TieWay59 (due to previous work on trait impls)

@joshka joshka added this to the v0.23.0 milestone Aug 22, 2023
Use strum for most of these, with a couple of manual implementations,
and related tests
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #425 (3c455bf) into main (6153371) will increase coverage by 0.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   86.41%   87.11%   +0.69%     
==========================================
  Files          40       40              
  Lines        9432     9818     +386     
==========================================
+ Hits         8151     8553     +402     
+ Misses       1281     1265      -16     
Files Changed Coverage Δ
src/backend/mod.rs 82.92% <100.00%> (+49.59%) ⬆️
src/layout.rs 98.48% <100.00%> (+1.76%) ⬆️
src/symbols.rs 72.41% <100.00%> (+29.55%) ⬆️
src/terminal.rs 58.30% <100.00%> (+2.56%) ⬆️
src/title.rs 100.00% <100.00%> (ø)
src/widgets/block.rs 86.47% <100.00%> (+0.28%) ⬆️
src/widgets/canvas/map.rs 55.55% <100.00%> (+55.55%) ⬆️
src/widgets/chart.rs 97.84% <100.00%> (+0.05%) ⬆️
src/widgets/scrollbar.rs 90.22% <100.00%> (+1.19%) ⬆️
src/widgets/sparkline.rs 91.12% <100.00%> (+1.86%) ⬆️
... and 1 more

@joshka joshka added this pull request to the merge queue Aug 23, 2023
Merged via the queue into ratatui:main with commit 98155dc Aug 23, 2023
@joshka joshka deleted the display-trait branch August 23, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: implement common traits
2 participants