fix(layout): ensure left <= right #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent refactor missed the positive width constraint
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 86.10% 86.14% +0.04%
==========================================
Files 40 40
Lines 9227 9256 +29
==========================================
+ Hits 7945 7974 +29
Misses 1282 1282
|
hasezoey
reviewed
Aug 17, 2023
|
can confirm that this change gives the behavior of before #405 in #404 again (behavior mentioned in #404 (comment)) |
kdheepak
approved these changes
Aug 17, 2023
orhun
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactor (#405) missed the positive width constraint:
https://github.com/ratatui-org/ratatui/blob/ea48af1c9abac7012e3bf79e78c6179f889a6321/src/layout.rs#L380-L381
Addresses the bug noticed in #404 (comment)
ping @hasezoey - I took a quick look and this may change a few tests on #404. It might not yet be perfect and it may change again if #408 is merged on top of this.